Feature: Added move query functionality to Heihachi frame data bot #23
+398
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarquisSimmons
changed the title
MarquisSimmons
changed the title
|
@MarquisSimmons I don't have intellij installed anymore x_x and it seems the check is failing, would you be able to fix it? |
Yep Ill look into it, |
MarquisSimmons
force-pushed
the
marquis/frame-query
branch
from
3e2b08b to
d213f00
Compare
- Updated character_command_factory to suppot looking up characters by their aliases without '/fd'
MarquisSimmons
force-pushed
the
marquis/frame-query
branch
from
d213f00 to
8584a73
Compare
|
@TLNBS2405 looks like we should be all set! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
/fdWhy:
To extend the functionality of the bot. During development I realized that the alias lookup was only enabled for the
/fdcommand. From my personal experience most people just use/characterso I enabled aliases there as well.How:
I added a new move search command
/msthat takes in acondition(>, <, == etc.)frame_value,situation(hit, block, startup). This data is all used to traverse the character's move-list json to find applicable moves.I noticed some of the data was malformed so I also created a
_sanitize_frame_datafunction to clean those up before comparison.I flatted the aliases from
CHARACTER_ALIASand combined them with the list ofCharacterNamesSearching moves by frames
Short hand character lookup by alias
